Skip to Content

Changes for page Attachments

Last modified by Ricardo Julio Rodríguez Fernández on 2026/09/01 20:31
From version 5.1
edited by Ricardo Julio Rodríguez Fernández
on 2026/05/30 00:25
Change comment: Install extension [org.xwiki.platform:xwiki-platform-attachment-ui/18.4.0]
To version 6.1
edited by Ricardo Julio Rodríguez Fernández
on 2026/09/01 20:31
Change comment: Install extension [org.xwiki.platform:xwiki-platform-attachment-ui/18.7.0]

Summary

Details

Page properties
Content
... ... @@ -34,7 +34,7 @@
34 34  #**
35 35   * Displays the attachment gallery as a list of attachment boxes, starting with special boxes for uploading a new attachment and for setting a default value.
36 36   *
37 - * @param $targetDocument the document to recieve the field value being modified
37 + * @param $targetDocument the document to receive the field value being modified
38 38   * @param $targetAttachDocument the document to list/save attachments to
39 39   * @param $options generic picker options
40 40   *#
XWiki.JavaScriptExtension[0]
Code
... ... @@ -319,8 +319,8 @@
319 319   document.observe('xwiki:dom:loaded', function() {
320 320   $$('.attachment-picker-start').invoke('observe', 'click', function(event) {
321 321   event.stop();
322 - var targetElement = event.element();
323 - var url = targetElement.href;
322 + const targetElement = event.target.closest('.attachment-picker-start');
323 + let url = targetElement.dataset.modalUrl;
324 324   if (url.indexOf('?') < 0) {
325 325   url += '?';
326 326   }
XWiki.WikiMacroClass[0]
Macro code
... ... @@ -146,9 +146,17 @@
146 146   #if ($hasTargetDoc)
147 147   #set ($queryString.targetdocname = $targetdoc.fullName)
148 148   #end
149 - #set ($linkLabel = $services.rendering.escape($services.rendering.escape($buttontext, 'xwiki/2.1'), 'xwiki/2.1'))
150 - (% class="buttonwrapper" %)[[$linkLabel>>${xcontext.macro.doc.fullName}||queryString="$escapetool.url($queryString)"
151 - class="attachment-picker-start button" title="$services.rendering.escape($buttontext, 'xwiki/2.1')"]](%%)##
149 + #set ($linkLabel = $escapetool.xml($buttontext))
150 + #set ($modalUrl = $escapetool.xml("$xcontext.macro.doc.URL?$escapetool.url($queryString)"))
151 + {{html clean="false"}}
152 + <p>
153 + <span class="buttonwrapper">
154 + <button type="button" class="attachment-picker-start button"
155 + title="$!{linkLabel}"
156 + data-modal-url="${modalUrl}">$!linkLabel</button>
157 + </span>
158 + </p>
159 + {{/html}}##
152 152   #end
153 153  #end
154 154  {{/velocity}}